Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landcover related landuse should all show at zoom 9 #1813

Closed
nvkelso opened this issue Feb 2, 2019 · 7 comments
Closed

Landcover related landuse should all show at zoom 9 #1813

nvkelso opened this issue Feb 2, 2019 · 7 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Feb 2, 2019

http://localhost:8007/#9/38.1648/-121.2671

We're showing some landcover type landuse starting at zoom 9 (like grassland), and others at zoom 10 and other zooms. They should all come in at the same zoom (9), when we switch to OSM data source.

image

Versus zoom 10, which adds farmland:

image

@nvkelso nvkelso added this to the v1.7.0 milestone Feb 2, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Feb 2, 2019

tl;dr

  • Looks like farmland is the big offender here. It needs to start at zoom 9 not 10.
  • We may also want to move orchard to zoom 9 as well.
  • Generally we include the rest at zoom 9 already if they are large, and throttle the smaller ones for later zooms (eg filter: { landuse: forest } with min_zoom: { max: [ 9, *tier2_min_zoom ] }. That seems to be working for us, but it could also be creating holes for us.
    • Around Concord, California (11/37.9512/-121.9860) I zoom in / out and I see little polygons being dropped at lower zooms

image

Research:

Related to #1259 and #1788.

From that issue's description of low zoom landcover:

landuse IN
  farmland (and farm), modify the min to be 9 instead of 10.
  orchard, starts at 10 now, should be 9?
  forest – do we need a custom `tier2_min_zoom` to show all at zoom 9?
  residential - okay to start at 10, because of NE overlap
  commercial - okay to start at 10, because of NE overlap
  retail - okay to start at 10, because of NE overlap
  industrial - okay to start at 10, because of NE overlap
  meadow, starts at 9, but throttled
  vineyard, starts at 9, but throttled
natural IN
  wood – do we need a custom `tier2_min_zoom` to show all at zoom 9?
  sand - starts at 9, but throttled
  scree - starts at 9, but throttled
  shingle - starts at 9, but throttled
  bare_rock - starts at 9, but throttled
  heath - starts at 9, but throttled
  grassland - starts at 9, but throttled
  scrub - starts at 9, but throttled
natural IN
  wetland - starts at 9, but throttled
  mud - starts at 9, but throttled

@nvkelso
Copy link
Member Author

nvkelso commented Feb 2, 2019

I also wonder if we should be including all the "urban" content in a big union separate from any remapping – that way we'd get maximum urban_area polygon at mid-zooms, while preserving when individual overlays like hospital, school, parking lot come in?

See 12/37.9778/-122.0918.

image

@nvkelso
Copy link
Member Author

nvkelso commented Feb 2, 2019

Most this pink forest is only visible at zoom 10 not zoom 9 around 10/32.8367/35.6391 in Israel.

image

@nvkelso
Copy link
Member Author

nvkelso commented Feb 4, 2019

Around Watsonville, California (12/36.8614/-121.7199)

image

@zerebubuth
Copy link
Member

Related: #1794.

@nvkelso
Copy link
Member Author

nvkelso commented Feb 5, 2019

Moving the patchy landuse subissue here to it's own issue for next milestone in #1822.

@nvkelso
Copy link
Member Author

nvkelso commented Feb 14, 2019

The final QA changes for min_zoom are verified. Here for farmland:

image

@nvkelso nvkelso closed this as completed Feb 14, 2019
@ghost ghost removed the in review label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants