Defunct Tenderloin neighbourhood displays in NYC

[nvkelso]

Related to #1808.

• What did you see? This Tenderloin neighbourhood in NYC has been deprecated / not current in WOF since 2016, but is included in 2018-2019 builds of Tilezen.
• What did you expect to see? Not current, deprecated neighbourhoods should be excluded from the build.
• What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.
  • https://tangrams.github.io/refill-style/#15/40.7506/-73.9809
  • https://github.com/whosonfirst-data/whosonfirst-data/blob/master/data/858/697/25/85869725.geojson
• Screenshot?

[nvkelso]

By updating the WOF build via #1808 I initially thought we'd remove the bad Tenderloin label, but it's been deprecated for such a long time there might be an additional logic error related to processing mz:is_current.

[zerebubuth]

I loaded up the WOF data locally to check, and got this result:

# select is_visible from wof_neighbourhood where wof_id = 85869725;
 is_visible 
------------
 f
(1 row)

If is_visible is false, that should mean it gets selected by neither the query code in vector-datasource nor the query code in raw-tiles. However, to be sure, we'll have to wait for the latest build to finish.

Although the property edtf:deprecated: 2016-08-16 suggests deprecation in 2016, it looks like the WOF record was last modified on 2018-05-25. The WOF pgdump we store on S3 says Last-Modified: Wed, 14 Mar 2018, which is before the WOF record was last changed. I'm not sure how to check the previous versions of a WOF record, but it seems possible that the deprecated date was modified after the last static dump we created.

[nvkelso]

Hard to say, even looking at the blame:

• https://github.com/whosonfirst-data/whosonfirst-data/blame/master/data/858/697/25/85869725.geojson

Let's wait for a new build before researching anymore :)

[nvkelso]

No longer in dev build, closing.