changed protocol to https #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'd like to merge this change, but as you can see from the CircleCI checks, it has some consequences for the tests. We're sorry; this isn't due to your patch. It's because a large number of tests rely on fetching external data from OSM or Overpass and the data has changed since the tests were written. We maintainers should change all the failing tests to include their own data (e.g: compare old style and new "generative" style), or at least the 32 which are causing the checks for this PR to fail. @nvkelso - what do you think? |
|
@zerebubuth I think it's fine to merge as-is and I'll file followup to update the tests (which I agree are from upstream data churn). |
|
Filed #1923 to track the generative test work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.