Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert poor tolerance roads and boundaries #1980

Closed
nvkelso opened this issue Oct 28, 2021 · 2 comments
Closed

Revert poor tolerance roads and boundaries #1980

nvkelso opened this issue Oct 28, 2021 · 2 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 28, 2021

When loading 512px tiles in MapboxGL versus Tangram there is a noticeable "off by one" geometry simplification level of detail difference for some layers, like roads and boundaries.

In #1718 we changed the tolerance for roads and boundaries layer to 2.0 from 1.0 to get a little bit smaller tile size. In retrospect the file savings were negligible but the visual effect is compounded in MapboxGL and should be reverted.

@nvkelso nvkelso added this to the v1.9.0 milestone Oct 28, 2021
@bcamper
Copy link
Collaborator

bcamper commented Oct 28, 2021

Just to clarify, rendering on these is the same in Tangram and Mapbox GL (both adhere to the 512px tile approach for these tiles).

@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

Fixed via #1988.

@nvkelso nvkelso closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants