Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always x-check country labels against Natural Earth #2077

Closed
nvkelso opened this issue Apr 28, 2022 · 2 comments
Closed

Always x-check country labels against Natural Earth #2077

nvkelso opened this issue Apr 28, 2022 · 2 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Apr 28, 2022

Every now and then a fake country pops up in OpenStreetMap (a problem). And every now and then new real countries pop up, though recognition by wider international audiences does lag (an opportunity).

Currently we do compare OSM countries with Natural Earth countries via transform.py#L8889-L8922.

For non-matching countries, I propose we additionally modify the kind value to unrecognized (in addition to limiting the min_zoom blast radius to say 8 instead of 6).

We should also update the note in https://github.com/tilezen/vector-datasource/blob/master/yaml/places.yaml#L146-L147

This would match more what we do for disputed boundaries that are default unrecognized:

@nvkelso
Copy link
Member Author

nvkelso commented Apr 28, 2022

Requires #2075

Related to #2076.

@nvkelso
Copy link
Member Author

nvkelso commented Oct 5, 2022

Fixed via #2068 and #2069.

@nvkelso nvkelso closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants