Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with min_zoom in Earth layer in v1.9.0 #2120

Open
rwrx opened this issue Dec 30, 2023 · 12 comments
Open

Problem with min_zoom in Earth layer in v1.9.0 #2120

rwrx opened this issue Dec 30, 2023 · 12 comments

Comments

@rwrx
Copy link
Contributor

rwrx commented Dec 30, 2023

Hello, thank you a lot for v1.9.0 release. I have tried it out, but I have encountered a problem with min_zoom for Earth layer. It is asserting on this line: https://github.com/tilezen/tilequeue/blob/master/tilequeue/process.py#L391

I have printed out data with which it has a problem:
(<shapely.geometry.polygon.Polygon object at 0x7f4d2d4ce390>, {'source': 'osmdata.openstreetmap.de', 'min_zoom': None, 'area': None}, 178712, Metadata(source='shp'))

I am not sure how to debug it more or when the problem could be. Could I ask you for assitence resolving this issue? Thank you a lot.

@nvkelso
Copy link
Member

nvkelso commented Dec 31, 2023

Hey there stranger!

It's possibly related to this PR? https://github.com/tilezen/vector-datasource/pull/1858/files

Note that PR requires an updated version of Tilequeue, are you using the newer version?

Please note: development of Vector-Datasource has been stopped. The Tilezen schema is still evolving (and actively being reimplemented) over at Protomaps > Basemaps. The build system there using Planetiler can generate the whole world very quickly even on a single machine at extremely low cost.

@rwrx
Copy link
Contributor Author

rwrx commented Jan 2, 2024

Hi @nvkelso!

Thank you a lot for your really fast answer. Yes, it is possibly related to this PR. I have pulled it from this git repo and prepared Slovakia osm extract. Yes, I am using latest version of Tilequeue. Could I just comment out that assert line? Or how to fix it? I have tried something, but I did not found out why it does not contain min_zoom property for earth layer. All other layers are ok.

Thank you for mentioning that develoment o Vector-Datasource has been stopped. It is looking really good. :) It could be later used also as a replacement for Vector-Datasource and Tangram pipeline?

@nvkelso
Copy link
Member

nvkelso commented Jan 2, 2024

Yes, that's the goal (replacement). The basic setup works well now but it'll take a while to come to full feature parity for extras like road shields.

@nvkelso
Copy link
Member

nvkelso commented Jan 2, 2024

If you don't need the earth layer then try commenting that out in the main layers yaml config?

https://github.com/tilezen/vector-datasource/blob/master/queries.yaml

It's probable that earth and transit layers were disabled via an override during final QA of v1.9 which could explain this bug?

@rwrx
Copy link
Contributor Author

rwrx commented Jan 2, 2024

That is great. But will tangram styles work in MapLibre? Or will MapLibre styles use also Vector-datasource scheme?

I also need earth layer. I am not sure if it is possible that they were disabled during final QA of v1.9. I am not sure where to look why osmdata.openstreetmap.de earth layer features does not contain min_zoom property. Maybe there is something missing in data import or processing data after import.

@nvkelso
Copy link
Member

nvkelso commented Jan 2, 2024

Styles have to be ported to MapLibre, and MapLibre doesn't support all the options Tangram had. But onward...

There are a few Protomaps styles now that are feature complete and workable. But no outdoor specific style yet.

If you need help with a migration strategy I'm happy to talk live on a call. My username here at gmail.com and we can find time this week or later this month.

@nvkelso
Copy link
Member

nvkelso commented Jan 2, 2024

(I'll try to debug the earth layer issue tomorrow for you...)

@rwrx
Copy link
Contributor Author

rwrx commented Jan 2, 2024

Thank you a lot. I will write you an e-mail. Also thank you a lot that you will debug it.

@rwrx
Copy link
Contributor Author

rwrx commented Jan 3, 2024

I have also noticed that for v1.9 I am gettng empty tiles. For example 0/0/0 (zoom/x/y) tile has no data when I imported slovakia.osm.pbf. I am still using import script based on https://github.com/tilezen/vector-datasource/wiki/Mapzen-Vector-Tile-Service

@rwrx
Copy link
Contributor Author

rwrx commented May 30, 2024

Basically we fixed this with @nvkelso by commenting out this line:

psql $PSQLOPTS $@ -f apply-highway_99_fixes.sql

@nvkelso
Copy link
Member

nvkelso commented May 30, 2024

@rwrx Can you remind me what the error was? Something about miss-matched projections?

@rwrx
Copy link
Contributor Author

rwrx commented May 31, 2024

@nvkelso Yes, the error was:

Fixing funky road classification in Seattle, Washington, USA in OSM
psql:apply-highway_99_fixes.sql:6: ERROR:  Geometry SRID (0) does not match column SRID (3857)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants