Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central Park park label shouldn't be in the water #405

Open
nvkelso opened this issue Nov 11, 2015 · 1 comment
Open

Central Park park label shouldn't be in the water #405

nvkelso opened this issue Nov 11, 2015 · 1 comment

Comments

@nvkelso
Copy link
Member

nvkelso commented Nov 11, 2015

This is probably true for any landuse label. Should we subtract out the water before creating the label point?
#15/40.7867/-73.9577

screen shot 2015-11-11 at 13 16 40

@nvkelso nvkelso added the bug label Nov 11, 2015
@zerebubuth
Copy link
Member

Subtracting out the water (or indeed buildings, or anything else displayed "in front of" the park) would mean that the ordering of these features would be set on the server. For example, if there's a park with a sports pitch in the centre, which itself has a pond in the centre (maybe it's a steeplechase pitch or something?) then we'd have to label the park minus the pitch, but also the pitch minus the pond, which implies the relative ordering of features and their visibility on the server is the same as the draw order or z-order on the client.

This isn't a problem per-se, but we might want to think carefully about whether we want to tie the tiles so strongly to a particular ordering, or whether there's any benefit from being able to label better if the style doesn't choose to draw the "subtracted" type of areas (e.g: water, buildings, sports pitches, playgrounds, etc...). Additionally, whether we want the label position to move when we start/stop showing features (e.g: at the zoom at which we drop the Jackie O Reservoir).

(Also, tilezen/tilequeue#53 - there's some weirdly labelled points in the screenshot above.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants