Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOF neighbourhoods should export localized names #418

Closed
nvkelso opened this issue Dec 4, 2015 · 11 comments
Closed

WOF neighbourhoods should export localized names #418

nvkelso opened this issue Dec 4, 2015 · 11 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 4, 2015

https://whosonfirst.mapzen.com/spelunker/id/85910293/

This neighbourhood has a default name in Japanese, which is what we're exporting as the name in tiles. But there are other languages, and we should export those, too.

@nvkelso nvkelso added this to the v0.7.0 milestone Dec 4, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 4, 2015

/cc @thisisaaronland

@nvkelso nvkelso added ready and removed ready labels Jan 8, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Jan 15, 2016

Moving out of the v0.7 milestone to load balance.

There's also some changes in the works on the WOF side for default name and localized names that might require additional work, so would like to batch with that.

Plus Tangram still doesn't have ability to auto-switch displayed languages, so...

@nvkelso nvkelso modified the milestones: v0.8.0, v0.7.0 Jan 15, 2016
@nvkelso nvkelso added the ready label Jan 22, 2016
@nvkelso nvkelso removed the ready label Feb 4, 2016
@nvkelso nvkelso modified the milestones: v0.9.0, v0.8.0 Feb 9, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Feb 9, 2016

And again to v0.9

@thisisaaronland
Copy link

See also: whosonfirst-data/whosonfirst-data#183

@rmarianski
Copy link
Member

@zerebubuth what do you think of making a new hstore column in the database to store all of these? That way, we can include it as the tags value in the query, and it should just get included in the output via the usual transform. We'd have to make sure that we used the same i18n scheme as osm when we save the data, or maybe it makes more sense to have the transform be more flexible to support both schemes.

@zerebubuth
Copy link
Member

zerebubuth commented May 12, 2016

Hstore sounds good.

If we start translating between schemes, then it makes it more work for us later on. Reading the WOF name docs I'm confused as it keeps referring to country codes, and we use ISO 639-1 language codes...

I feel it might be easier to just expose the data that WOF has and let whoever's making the map choose what's the appropriate country / language codes for them.

@nvkelso
Copy link
Member Author

nvkelso commented May 12, 2016

We need should resolve this inconsistency for customers on the server as part of this issue.

On May 12, 2016, at 03:22, Matt Amos notifications@github.com wrote:

Hstore sounds good.

If we start translating between schemes, then it makes it more work for us later on. Reading the [WOF name docs] I'm confused as it keeps referring to country codes, and we use ISO 639-1 language codes...

I feel it might be easier to just expose the data that WOF has and let whoever's making the map choose what's the appropriate country / language codes for them.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@rmarianski
Copy link
Member

@dianashk we'd like to be consistent with what you end up doing in search. What do you think?

@thisisaaronland
Copy link

That the WOF documentation refers to country codes is a bug. The docs mean to indicate that we are using ISO-639-3 language codes. See also:

https://www.w3.org/International/articles/language-tags/#language

I will update the docs, shortly, when I am not using my hands to put food in my mouth...

@rmarianski
Copy link
Member

Just spoke with @dianashk and @orangejulius, and we'll update to use iso-693-3 codes across the board. We'll normalize the tags from osm to convert the iso-693-1 codes to iso-693-3 codes.

@nvkelso
Copy link
Member Author

nvkelso commented Aug 10, 2016

This is pretty awesome :)

screen shot 2016-08-09 at 23 13 23

screen shot 2016-08-09 at 23 13 37

/cc @thisisaaronland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants