-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WOF neighbourhoods should export localized names #418
Comments
/cc @thisisaaronland |
Moving out of the v0.7 milestone to load balance. There's also some changes in the works on the WOF side for default name and localized names that might require additional work, so would like to batch with that. Plus Tangram still doesn't have ability to auto-switch displayed languages, so... |
And again to v0.9 |
See also: whosonfirst-data/whosonfirst-data#183 |
@zerebubuth what do you think of making a new hstore column in the database to store all of these? That way, we can include it as the tags value in the query, and it should just get included in the output via the usual transform. We'd have to make sure that we used the same i18n scheme as osm when we save the data, or maybe it makes more sense to have the transform be more flexible to support both schemes. |
Hstore sounds good. If we start translating between schemes, then it makes it more work for us later on. Reading the WOF name docs I'm confused as it keeps referring to country codes, and we use ISO 639-1 language codes... I feel it might be easier to just expose the data that WOF has and let whoever's making the map choose what's the appropriate country / language codes for them. |
We need should resolve this inconsistency for customers on the server as part of this issue.
|
@dianashk we'd like to be consistent with what you end up doing in search. What do you think? |
That the WOF documentation refers to country codes is a bug. The docs mean to indicate that we are using ISO-639-3 language codes. See also: https://www.w3.org/International/articles/language-tags/#language I will update the docs, shortly, when I am not using my hands to put food in my mouth... |
Just spoke with @dianashk and @orangejulius, and we'll update to use iso-693-3 codes across the board. We'll normalize the tags from osm to convert the iso-693-1 codes to iso-693-3 codes. |
This is pretty awesome :) /cc @thisisaaronland |
https://whosonfirst.mapzen.com/spelunker/id/85910293/
This neighbourhood has a default name in Japanese, which is what we're exporting as the name in tiles. But there are other languages, and we should export those, too.
The text was updated successfully, but these errors were encountered: