Deal with US National Forest, US National Park server side

[nvkelso]

This type of filter evaluation (on operator) is too prevalent in the stylesheet:

    landuse:
        data: { source: osm }
        tier1:
            filter: 
                any:
                    # limit show smaller landuse areas to higher zooms
                    - { $zoom: { min: 3 },  area: { min: 300000000 } }
                    - { $zoom: { min: 4 },  area: { min: 300000000 } }
                    - { $zoom: { min: 5 },  area: { min: 150000000 } }
                    - { $zoom: { min: 6 },  area: { min: 150000000 } }
                    - { $zoom: { min: 7 },  area: { min: 100000000 } }
                    - { $zoom: { min: 8 },  area: { min: 10000000 } }
                    - { $zoom: { min: 9 },  area: { min: 5000000 } }
                    - { $zoom: { min: 10 }, area: { min: 1000000 } }
                    - { $zoom: { min: 11 }, area: { min: 500000 } }
                    - { $zoom: { min: 12 }, area: { min: 500000 } }
                    - { $zoom: { min: 13 }, area: { min: 100000 } }
                    - { $zoom: { min: 14 }, area: { min: 50000 } }
                    - { $zoom: { min: 15 }, area: { min: 20000 } }
                    - { $zoom: { min: 15 }, area: { min: 2000 } }
                    - { $zoom: { min: 16 } }
            national_park:
                filter: { kind: [national_park, "park or protected land"], not: { operator: [ "United States Forest Service", "US Forest Service", "U.S. Forest Service", "USDA Forest Service" ] } }
                draw:
                    polygons:
                      color: *green7
                us_national_park:
                    # yosemite national park, death valley national park, grand canyon national park
                    filter: { operator: [ "United States National Park Service", "US National Park Service" ] }
                    draw:
                        polygons:
                            color: *green1

[zerebubuth]

This is kind of a fudge in the style sheet to handle wanting to draw US National Parks differently from other large parks (#227), which is really a cartographic decision. Pushing this into the vector source feels, to me, like specialising the data source and reducing its usefulness; it seems like we're moving beyond "cleaning up" the data and into "opinionating" the data.

[bcamper]

While I agree it's opinionated (which I am personally fine with as long as we do it responsibly), I also feel like it represents a kind of data normalization issue that is likely to be useful beyond our specific designs. One way to accomplish this type of thing could be to have an additional or alternate field, in case one wants to access the original data. There's a balance in changing underlying data vs. additively providing an opinion on top of it.

[nvkelso]

For operator, we standardize other non-conventional (or misspelled) tags to the conventional value elsewhere in the code, this seems like the same thing?

In terms of National Parks versus National Forests, there's other things we can look at here (like the protected_class stuff), like populating it explicably on National Forests and US National Parks when it's not provided in data.

[nvkelso]

Splitting of the operator part into #927.

[nvkelso]

#473 should most address this.

Moving this to v1.1 to track any additional cleanup that might be needed.

[nvkelso]

Don't think this is an issue anymore.