Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote aerialway stations & railway tram_stops and halts #587

Closed
nvkelso opened this issue Mar 10, 2016 · 7 comments
Closed

Promote aerialway stations & railway tram_stops and halts #587

nvkelso opened this issue Mar 10, 2016 · 7 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Mar 10, 2016

  • What did you see? I only see the station for aerialway and for tram_stops at zoom 15.
  • What did you expect to see? I expect to see them earlier at zoom 13 in tiles. I might only show them with a symbol (no text part of the label) at zoom 13, but including them there shows the shape of the network. Similarly we're missing the calculated kind_tile_rank attribute on these.
  • What map location are you having problems with? London, San Francisco, Berlin
  • Screenshot? See below.

In functions.sql we're hard coding the zoom of these features to zoom 15:

            OR aerialway_val IN ('station')
            OR railway_val IN ('halt', 'tram_stop')
        THEN 15

There usually isn't an area associated with these (preventing the area scaling like with railway stations), so try adding them at zoom 13.

More complex, and probably a different ticket? If one of these is a "transfer" station where two lines come intersect (but not in a sequence running parallel), I could see zoom 12. And if it's the terminal station on the line then zoom 11.

screen shot 2016-03-10 at 11 00 15

screen shot 2016-03-10 at 10 59 55

screen shot 2016-03-10 at 10 50 11

screen shot 2016-03-10 at 10 49 55

screen shot 2016-03-10 at 10 49 39

screen shot 2016-03-10 at 10 49 33

@nvkelso
Copy link
Member Author

nvkelso commented Mar 18, 2016

Tile sync: Let's just do zoom 13 change now.

Depending on how these feels in tiles, we can revisit adding a tile_kind_rank to them later.

@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

Overall good, but I see tram_stop features marked as min_zoom:11 in tiles which is too early. They should be zoom 13 instead.

In the PR I see this was zoom 13, but it was later set to 11 in 31d2c0e. I'm pretty sure 13 is what we want and looks best, but was there a reason for the zoom 11 change? See below...

screen shot 2016-03-24 at 00 27 23

screen shot 2016-03-24 at 00 23 17

@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

It's probably because railway=halt, and railway=stop were requested to be at zoom 11 in another issue, but tram_stop at zoom 13 here? Split those two into different lines in the CSV? Scratch that – all of these should be at zoom 13. That's what OSM.org transit layer does, feels right in QA testing here.

@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

aerialway=station is showing up at zoom 13 now, good:

screen shot 2016-03-24 at 00 35 57

@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

railway=halt are showing up near Zug Switzerland now #12/47.1769/8.4923, QA pass:

screen shot 2016-03-24 at 00 46 53

@rmarianski
Copy link
Member

@nvkelso yea, I saw in the description for #469 that tram_stops should be at z11. The pr above will move them to z13.

@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants