Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transit layer's route_name should be simply name #729

Closed
nvkelso opened this issue Apr 17, 2016 · 3 comments
Closed

Transit layer's route_name should be simply name #729

nvkelso opened this issue Apr 17, 2016 · 3 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Apr 17, 2016

The convention in Mapzen vector tiles is to have name regardless of source OSM feature type. But I see route_name on all transit line features.

(In this case we also indicate that "osm_relation": true, on these features already.)

Example 1:

{
"colour":
"#008752",
"id":
-3433314,
"kind":
"light_rail",
"operator":
"San Francisco Municipal Railway",
"osm_relation":
true,
"ref":
"M",
"route_name":
"M-Ocean View: Outbound to Balboa Park",
"sort_key":
418
},
"type":
"LineString"

Example 2:

{
"colour":
"red",
"id":
-2851509,
"kind":
"subway",
"operator":
"BART",
"osm_relation":
true,
"ref":
"Red",
"route_name":
"Richmond-Daly City",
"sort_key":
275
},
"type":
"LineString"
},
@nvkelso nvkelso added this to the v1.0.0 milestone Apr 17, 2016
@nvkelso nvkelso added the ready label May 9, 2016
@rmarianski
Copy link
Member

We have a transform that removes route_name from the results if it's the same as name. Presumably there are cases where route_name is not the same value as name?

How about:

  • if route_name exists but not name -> move to name
  • if name exists and equals route_name -> drop route_name
  • if both exist and are different -> keep both

We have this transform configured for the roads layer too.

@nvkelso
Copy link
Member Author

nvkelso commented May 10, 2016

Sounds good to me :)

@nvkelso
Copy link
Member Author

nvkelso commented Aug 10, 2016

Working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants