Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): allow a generic reducer (ngrx/platform #2996) #13

Merged
merged 1 commit into from
Jun 11, 2022
Merged

fix(store): allow a generic reducer (ngrx/platform #2996) #13

merged 1 commit into from
Jun 11, 2022

Conversation

preda7or
Copy link
Contributor

To solve immerOn type issues I followed the solution used in ngrx/platform#2996 to fix generic reducer type mismatch with ngrx/platform.

image

image

timdeschryver
timdeschryver approved these changes Jun 11, 2022
View reviewed changes
Copy link
Owner

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@timdeschryver timdeschryver merged commit 615e722 into timdeschryver:main Jun 11, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preda7or @timdeschryver