feat: add immerPatchState
#24
Conversation
`immerPatchState` adds mutable changes to the Signal Store. It requires at least version 17.1.1 since it needs to have access to `SignalState`.
There was a problem hiding this comment.
Thanks @rainerhahnekamp !
Before approving this, I want to make sure that the build etc is correctly set up. I'll verify this later today/tomorrow.
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
| } | ||
|
|
||
| export function immerPatchState<State extends object>(state: StateSignal<State>, ...updaters: Array<Partial<State & {}> | PartialStateUpdater<State & {}> | ImmerStateUpdater<State & {}>>) { |
There was a problem hiding this comment.
I wonder if we can update the generics to be able to do the following:
- the second patch updates the state and knows there a request state
- the first patch does the same but the state gets narrowed down because of the use of
setAllEntities
There was a problem hiding this comment.
Something like the following seems to work:
export declare function immerPatchState<State extends object, T = State>(state: StateSignal<T>, ...updaters: Array<Partial<T & {}> | PartialStateUpdater<T & {}> | ImmerStateUpdater<T & {}>>): void;
There was a problem hiding this comment.
Hi Tim, I can't currently work on it, but please update my branch as you wish. I'll continue tomorrow.
There was a problem hiding this comment.
You can ignore this.
In WebStorm this was working, after setting the TS version of Visual Studio Code to the installed version it does work.
Sorry for the confusion.
Let's ship this! 🚀
|
Thanks for the implementation @rainerhahnekamp ! |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Looking forward to your review.
As discussed earlier:
TestBed.flushEffects()SignalState