-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Dark/Light Text Colours in Legend #56
Comments
Here's the relevant code @hrbrmstr uses in statebins to switch from 'dark' or 'light' text. |
Thanks for pointing that out. However, sunburstR doesn't create a ggplot object, right? How would you use that function to change the text colour here? If I assign the above plot to an object, I get |
That wasn't meant as a tip to resolve your immediate problem. It was a tip to @timelyportfolio or possibly future me for a way to integrate this into the package. |
Sounds great, @timelyportfolio. @cjyetman sorry if I sounded a tad brash earlier, I was just confused. |
Great, I will try to submit to CRAN this week after a couple more rounds of testing. |
@ciflikli, on CRAN now, so will close but please feel free to reopen. |
Similar to this implementation in statebins (explained in the second code chunk in Downsizing) is it possible to supply different text colours to the legend to maximise legibility? For example, in the below example, light colours would keep the black text, but the darker shades would get white:
The text was updated successfully, but these errors were encountered: