Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting on number of children seems to have regressed #373

Open
KristofferC opened this issue Jan 18, 2024 · 2 comments
Open

Sorting on number of children seems to have regressed #373

KristofferC opened this issue Jan 18, 2024 · 2 comments

Comments

@KristofferC
Copy link
Collaborator

              68: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::IRTools.Inner.Block, ::Any) (1 children)
              69: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::IRTools.Inner.Variable, ::Any) (16 children)
              70: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::IRTools.Inner.IR, ::Any) (4 children)
              71: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Expr, ::Any) (13 children)
              72: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (6 children)
              73: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (1 children)
              74: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (4 children)
              75: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Nothing, ::Any) (1 children)
              76: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (5 children)
              77: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (1 children)
              78: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (4 children)
              79: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (1 children)
              80: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (1 children)
              81: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::LLVM.LLVMType, ::Any) (1 children)
              82: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Core.MethodInstance, ::Any) (3 children)
              83: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Core.MethodInstance, ::Any) (1 children)
              84: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::String, ::Any) (3 children)
              85: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Core.MethodInstance, ::Any) (4 children)
              86: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::LLVM.Function, ::Any) (1 children)
              87: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Tuple{String, Vector{Base.StackTraces.StackFrame}, Any}, ::Any) (12 children)
              88: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::String, ::Any) (2 children)
              89: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Vector{Base.StackTraces.StackFrame}, ::Any) (1 children)
              90: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Base.StackTraces.StackFrame, ::Any) (1 children)
              91: superseding isequal(x, y) @ Base operators.jl:133 with MethodInstance for isequal(::Symbol, ::Any) (1 children)

From the docs:

The most consequential ones (the ones with the most children) are listed last, and should be where you direct your attention first.

@xlxs4
Copy link

xlxs4 commented Jan 26, 2024

I've come across this 3 weeks ago, if that helps.

julia> methinvs.backedges
14-element Vector{SnoopCompile.InstanceNode}:
 MethodInstance for Base.unsafe_convert(::Union{Type{Ptr{T}}, Type{Ptr{Nothing}}}, ::Base.RefValue{T}) where T at depth 0 with 1 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 0 with 2 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 1 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 356 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 1 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 3 children
 
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 3 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 1 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 3 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 1 children
 MethodInstance for Base.unsafe_convert(::Type{Ptr{T}}, ::Base.RefValue{T}) where T<:Function at depth 1 with 3 children

@timholy
Copy link
Owner

timholy commented Jan 27, 2024

Yeah, there's a lot broken right now. Currently waiting on JuliaLang/julia#53020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants