Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing behaviour ignoring types #25

Open
Adam-Burke opened this issue Sep 24, 2019 · 1 comment
Open

Confusing behaviour ignoring types #25

Adam-Burke opened this issue Sep 24, 2019 · 1 comment

Comments

@Adam-Burke
Copy link

Adam-Burke commented Sep 24, 2019

As this tool is used for tests, it expands all of the fields in a query. There might be recursive fields in the query, so gqlg ignores the types which have been added in the parent queries already.

The current behaviour only returns the first matched query in the depth first traversal behaviour not the shallowest in the tree. Is this what the above intends?

So if you have object nesting like the following

thing {
    thing {
        thing2 {
             thing3 {
                  thing4
              }
        }
    }
    thing3 {
       thing4
    }
}

Depending on the order of your fields it will return different queries. Some with the thing.thing3.thing4 and others with it nested inside thing.thing2.thing3.thing4.

Sorry I'm new to this stuff. My terminology sucks. Hope I'm making some sense.

@Adam-Burke
Copy link
Author

Seems this pr is trying to address this issue.

https://github.com/timqian/gql-generator/pull/13/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant