Skip to content

Fix SARIMAXModel saving init params #81

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 22, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Sep 22, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 22, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review September 22, 2021 13:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #81 (487f3a7) into master (d152d9a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   90.14%   90.23%   +0.08%     
==========================================
  Files          48       48              
  Lines        2152     2170      +18     
==========================================
+ Hits         1940     1958      +18     
  Misses        212      212              
Impacted Files Coverage Δ
etna/models/sarimax.py 93.87% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d152d9a...487f3a7. Read the comment docs.

@iKintosh iKintosh merged commit efa0aac into master Sep 22, 2021
@iKintosh iKintosh deleted the fix_sarimax_saving_params branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants