Skip to content

Create TSDataset 2.0 #876

Closed
alex-hse-repository opened this issue Aug 23, 2022 · 0 comments
Closed

Create TSDataset 2.0 #876

alex-hse-repository opened this issue Aug 23, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Aug 23, 2022

🚀 Feature Request

Improve the methods of TSDataset, remove the regressors and transforms logic for it.

Proposal

Improve TSDataset:

  1. Remove the self.transforms attribute -- dataset now does't store the transforms
  2. Improve methods fit, transform, fit_transform, inverse_transform
  • Change the signature to method(self, transforms: Sequence[NewTransform])
  • Remove the regressors logic and _update_regressors method
  • Now transform work with TSDataset
  1. Improve method make_future
  • Change the signature to make_future(self, future_steps: int, transforms: Sequence[NewTransform], tail_steps: int = 0) -> "TSDataset":
  • Improve the logic of the method according to the new transforms logic
  1. Drop the lines, where the TSDataset.transforms attribute is used

Test cases

  • Improve/remove the current tests where possible
  • Mark the other tests with @pytest.mark.xfail(reason="TSDataset 2.0")

Additional context

No response

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Aug 23, 2022
@alex-hse-repository alex-hse-repository added this to the TSDataset 2.0 milestone Aug 23, 2022
@alex-hse-repository alex-hse-repository self-assigned this Sep 8, 2022
@alex-hse-repository alex-hse-repository mentioned this issue Sep 26, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant