Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some time.Time String() expectations may break with go1.9 #190

Closed
glycerine opened this issue Aug 17, 2017 · 2 comments
Closed

some time.Time String() expectations may break with go1.9 #190

glycerine opened this issue Aug 17, 2017 · 2 comments

Comments

@glycerine
Copy link
Contributor

Just a heads up about go1.9rc2. I filed a ticket,

golang/go#21485

to discuss the breaking change.
@glycerine glycerine changed the title some time.Time serializations may break with go1.9 some time.Time String() expectations may break with go1.9 Aug 17, 2017
@glycerine
Copy link
Contributor Author

The changes needed in greenpack were pretty straightforward. msgp test changes should be similar. Here's my patch:

glycerine/greenpack@aa2720e

@klauspost
Copy link
Collaborator

Seems like this was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glycerine @klauspost