Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail if directory has a space #1388

Closed
shadowspawn opened this issue Nov 3, 2020 · 1 comment
Closed

Tests fail if directory has a space #1388

shadowspawn opened this issue Nov 3, 2020 · 1 comment
Assignees

Comments

@shadowspawn
Copy link
Collaborator

shadowspawn commented Nov 3, 2020

 FAIL  tests/command.default.test.js
 FAIL  tests/command.executableSubcommand.lookup.test.js

Test Suites: 2 failed, 42 passed, 44 total
Tests:       15 failed, 356 passed, 371 total

Example of unsafe code in tests:

const { stdout } = await execAsync(`node ${pm} --an-option`);

Uncovered when suggested adding Commander back into citgm:

@shadowspawn shadowspawn self-assigned this Nov 3, 2020
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Nov 10, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Dec 14, 2020
@shadowspawn
Copy link
Collaborator Author

Fix released in 6.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant