Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index templates could be xml #8

Closed
boilerroomdigital opened this issue Feb 3, 2017 · 2 comments
Closed

Index templates could be xml #8

boilerroomdigital opened this issue Feb 3, 2017 · 2 comments
Assignees
Labels

Comments

@boilerroomdigital
Copy link

Hello,

If I create an index template which is an xml file, Template Sync will either rename it to .html, or delete it and leave me with an index file that redirects to a 404.

In FileTemplates.php I updated line 58 to
if (! in_array('index.html', $templates) && ! in_array('index.xml', $templates) && ! in_array('index.rss', $templates) && ! in_array('index.js', $templates)) {

(since it could also be a js or rss page).

This kind of works (in that my index.xml page is left alone), but I'm also left with an index.html page which I don't need. Whenever I delete this, it comes back.

Thanks for a cool addon.

@tjdraper tjdraper self-assigned this Feb 3, 2017
@tjdraper tjdraper added the bug label Feb 3, 2017
@tjdraper
Copy link
Owner

tjdraper commented Feb 3, 2017

Mmm, yeah. Template Sync accounts for various types, except apparently the index template. I’ll look into it as soon as I can.

@tjdraper
Copy link
Owner

tjdraper commented Feb 6, 2017

Should be resolved in 1.1.1. Reopen and let me know if you run into anymore trouble related to this. https://github.com/tjdraper/template-sync/releases/tag/1.1.1

@tjdraper tjdraper closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants