Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md #147

Open
rstacruz opened this issue Aug 25, 2016 · 5 comments
Open

CONTRIBUTING.md #147

rstacruz opened this issue Aug 25, 2016 · 5 comments
Labels

Comments

@rstacruz
Copy link
Contributor

I'd like to know how I can contribute additional functions.

Do I just create a new module?
What about updating the readme—is that automatically extracted from module docs?

(Specifically, I'd love a 101/reverse as an immutable version of Array.prototype.reverse :))

@rstacruz
Copy link
Contributor Author

@tjmehta
Copy link
Owner

tjmehta commented Aug 25, 2016

I would suggest creating an issue for quick discussion, and then PRing it. Sorry for not having a CONTRIBUTING.md :(. Everything is done manually right now. So you'll just have to modify the readme w/ docs for w.e you ad.

Random side note:
I want to add an index to the readme like in object-loops. Also, I definitely want to have the readme index sectioned by immutable methods. In a future breaking release, I would like to rename all immutable methods to be prepended w/ "immutable-" ("immutable-set" versus "put").

@tjmehta
Copy link
Owner

tjmehta commented Aug 25, 2016

In general, map utils fit in great w/ 101. There are typically, more in-depth discussions for more complex utils. Same goes w/ any utils that can be created by a composition. I know you're really active w/ OSS (We've chatted a few times and I've seen you're github activity), so I would love to have a smart person like you help me make these decisions.

@rstacruz
Copy link
Contributor Author

I would like to rename all immutable methods to be prepended w/ "immutable-"

👎 on this: it gives the impression that there are non-immutable methods in 101, which there shouldn't be!

@tjmehta
Copy link
Owner

tjmehta commented Aug 25, 2016

could prepend all mutable methods instead mutable-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants