Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntersectionObserverHooks has wrong definition of skipLazyLoading method #483

Closed
Burakovivan opened this issue Oct 26, 2020 · 1 comment · Fixed by #485
Closed

IntersectionObserverHooks has wrong definition of skipLazyLoading method #483

Burakovivan opened this issue Oct 26, 2020 · 1 comment · Fixed by #485
Labels

Comments

@Burakovivan
Copy link

Docs says this

Exact part im interested in is skipLazyLoading func, docs says it has one argument type of Attributes, and this does not relevant into real code (version 9.0.1 which are latest at the moment)

Class IntersectionObserverHooks has func skipLazyLoading which does not accept any arg, BUT it abstract parent do. Inheritance broken at some point, look this

IntersectionObserverHooks - skipLazyLoading(): boolean;
inherits
abstract SharedHooks - skipLazyLoading(): boolean;
inherits
abstract Hooks - abstracts skipLazyLoading(attributes: Attributes): boolean;

Problem at SharedHooks class. I believed i will fix that with argmunets[0], but it does not helps as code where this func called even does not put 'attributes' argument into func

@tjoskar
Copy link
Owner

tjoskar commented Nov 9, 2020

Hi @Burakovivan, sorry for the delay. I have not seen this issue until now. I agree it is a issue and it looks like @kp42 has a solution.

@tjoskar tjoskar added the bug label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants