Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect encoding for east asia characters #69

Closed
testercwt opened this issue Aug 10, 2020 · 2 comments
Closed

incorrect encoding for east asia characters #69

testercwt opened this issue Aug 10, 2020 · 2 comments

Comments

@testercwt
Copy link
Contributor

The constants.jl contains incorrect information for east asia character

here is the correct (east asia character) encodings as below

118 => "CP950",
119 => "EUC-TW",
123 => "BIG5-HKSCS",
125 => "GB18030",
126 => "CP936",
134 => "EUC-JP",
136 => "CP932",
138 => "CP932",
140 => "EUC-KR",
141 => "CP949"

ref
https://support.sas.com/documentation/onlinedoc/dfdmstudio/2.6/dmpdmsug/Content/dfU_Encodings_SAS.html

@testercwt testercwt changed the title correct encoding for east asia characters incorrect encoding for east asia characters Aug 10, 2020
@tk3369
Copy link
Owner

tk3369 commented Aug 10, 2020

Thanks. Do you mind submitting a PR? Do you have any test files with these encodings?

@testercwt
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants