Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimiVulpis: add collaborator #2556

Closed
sbrl opened this issue Nov 5, 2018 · 8 comments
Closed

AnimiVulpis: add collaborator #2556

sbrl opened this issue Nov 5, 2018 · 8 comments
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@sbrl
Copy link
Member

sbrl commented Nov 5, 2018

Hi, @AnimiVulpis! You seem to be enjoying contributing to the tldr-pages project. You now have had five distinct pull requests merged (#2544, #2542, #2541, #2540, #2539, #1591, #1590, #1589), which qualifies you to become a collaborator in this repository, as explained in our community roles documentation.

As a collaborator, you will have commit access and can therefore merge pull requests from others, label and close issues, and perform various other maintenance tasks that are needed here and there. Of course, all of this is voluntary — you're welcome to contribute to the project in whatever ways suit your liking.

If you do decide to start performing maintenance tasks, though, we only ask you to get familiar with the maintainer's guide.

Thanks for all your work so far!

@sbrl sbrl added the community Issues/PRs dealing with role changes and community organization. label Nov 5, 2018
@marpme
Copy link

marpme commented Nov 6, 2018

I totally agree adding him! I love his contributions, especially the hostess one as it brings a lot of values into tldr. I would love to see him further contributing in here ❤️

@waldyrious
Copy link
Member

waldyrious commented Nov 10, 2018

Hmm, reading the opening message above, I think we should end the template with an actionable note.

I would suggest such a note to ask them to (1) confirm their agreement that the invitation can be sent, and (2) close the issue once they accept it (thus confirming that the new permissions are in place).

What do you think @sbrl, @agnivade, @pxgamer, @mfrw?

@owenvoke
Copy link
Member

I think that sounds pretty good @waldyrious 👍

@mfrw
Copy link
Member

mfrw commented Nov 11, 2018

Yep that's a good idea.

@waldyrious
Copy link
Member

Cool, thanks all for the feedback. I've added a note to self to contribute that change soon-ish.

@AnimiVulpis
Copy link
Collaborator

Now that I accepted to become a collaborator, should I close this issue myself?

And thanks a lot 😄

@agnivade
Copy link
Member

According to this -

I would suggest such a note to ask them to (1) confirm their agreement that the invitation can be sent, and (2) close the issue once they accept it (thus confirming that the new permissions are in place).

Yes.

@sbrl
Copy link
Member Author

sbrl commented Nov 11, 2018

No problem! and yep, go ahead @AnimiVulpis :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

No branches or pull requests

7 participants