Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rlwrap: add page #11941

Merged
merged 8 commits into from
Dec 30, 2023
Merged

rlwrap: add page #11941

merged 8 commits into from
Dec 30, 2023

Conversation

sohang3112
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 0.43

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Dec 30, 2023
@vitorhcl vitorhcl self-requested a review December 30, 2023 13:44
vitorhcl
vitorhcl requested changes Dec 30, 2023
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I suggested some fixes to minor typos.

pages/common/rlwrap.md Outdated Show resolved Hide resolved
pages/common/rlwrap.md Outdated Show resolved Hide resolved
kbdharun
kbdharun reviewed Dec 30, 2023
View reviewed changes
pages/common/rlwrap.md Outdated Show resolved Hide resolved
@sohang3112 @kbdharun
rlwrap: Suggestion by kbdharun
ddfc2e2 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
kbdharun
kbdharun approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome to tldr and thanks for your contribution.

@kbdharun kbdharun requested a review from vitorhcl December 30, 2023 16:28
@sohang3112
Copy link
Contributor Author

Thanks for your contribution! I suggested some fixes to minor typos.

@vitorhcl I committed your suggestion by directly editing in code (not through Github "Accept suggestion" button). How can I tell Github that I have committed your suggestion?

@vitorhcl
Copy link
Member

Thanks for your contribution! I suggested some fixes to minor typos.

@vitorhcl I committed your suggestion by directly editing in code (not through Github "Accept suggestion" button). How can I tell Github that I have committed your suggestion?

You could re-request my review. @kbdharun already did that.

Thanks!

@sohang3112
Copy link
Contributor Author

@vitorhcl Hi. Please merge this PR since it has been approved now.

@vitorhcl vitorhcl merged commit fdf6549 into tldr-pages:main Dec 30, 2023
4 checks passed
@sohang3112 sohang3112 mentioned this pull request Mar 13, 2024
Open
24 tasks
@Managor Managor mentioned this pull request Sep 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck left review comments

@vitorhcl vitorhcl vitorhcl approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sohang3112 @CLAassistant @vitorhcl @sebastiaanspeck @kbdharun