Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule): Add required meta.fixable attribute #341

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Nov 2, 2021

Description

Eslint 8 requires adding a meta.fixable attribute to fixable rules: https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#fixes

How has this been tested?

I have added the same change on my project which couldn't be upgraded to eslint 8 because of this.

Types of changes

  • Test change (non-breaking change which adds additional test scenarios)
  • Refactor change (non-breaking change updates coding styles)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have ran npm run test and everything passes
  • My code follows the code style of this project
  • I have updated the documentation where necessary
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests pass

@DamienCassou DamienCassou marked this pull request as ready for review November 2, 2021 14:38
@DianaSuvorova
Copy link
Collaborator

Thank you 🙏

@DianaSuvorova DianaSuvorova merged commit 3a61ff2 into tlvince:master Nov 7, 2021
@tlvince
Copy link
Owner

tlvince commented Nov 24, 2021

🎉 This PR is included in version 4.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DamienCassou DamienCassou deleted the add-fixable-attribute branch November 24, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants