Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split groups performance pull request? #58

Open
jenseng opened this issue Oct 17, 2016 · 0 comments
Open

split groups performance pull request? #58

jenseng opened this issue Oct 17, 2016 · 0 comments

Comments

@jenseng
Copy link

jenseng commented Oct 17, 2016

A while back I opened a pull request to make TEST_QUEUE_SPLIT_GROUPS perform less pathologically (i.e. don't treat :all like :each). There were a couple problems with my first approach, but the pull request was closed without any comment or discussion from the maintainers.

I've reworked it since then to fix its shortcomings, and it has been performing quite well for canvas-lms (almost 20k non-selenium specs).

The tl;dr of it is it maintains queues at each level of the ExampleGroup hierarchy, such that no (sub-)group is ever split until its parent queue is empty. It's as if split groups is off, until there are no groups left, at which point the workers optimally swarm on the remaining items.

Now that test-queue is actively being maintained, would you have any interest in such a pull request? It would of course need to be rebased onto your latest work, and some of its independently developed things (e.g. TEST_QUEUE_LAZY_GROUPS) are now redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant