Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow un-authententicated download access to S3 repository #126

Closed
LesterTheTester opened this issue Jun 7, 2018 · 6 comments
Closed

Allow un-authententicated download access to S3 repository #126

LesterTheTester opened this issue Jun 7, 2018 · 6 comments

Comments

@LesterTheTester
Copy link

Enhancement Suggestion

Allow unauthenticated access to S3 for downloading dependencies

Why would the enhancement be useful to most users

An administrator could setup an S3 bucket that's read-accessible to the public, or under certain ACL conditions (IP, VPC, etc) that do not require AWS credentials. This would allow end users to consume dependencies without needing AWS credentials. At some organizations, AWS credentials are not handed out to everyone (ie, only infrastructure developers).

I'd suggest putting this behind a commandline flag, like --no-creds

@tmspzz
Copy link
Owner

tmspzz commented Jun 9, 2018

@LesterTheTester seems like a good idea. Do you want to give it a shot?

@tmspzz
Copy link
Owner

tmspzz commented Jul 9, 2018

@LesterTheTester I think it's enough to launch rome like so:

AWS_ACCESS_KEY_ID="" AWS_SECRET_ACCESS_KEY="" rome download

In narrator's voice: "No, it wasn't enough"

@samritchie
Copy link
Contributor

@blender I might have a look at this one. Are you thinking http-conduit and using the command line flag as proposed?

@tmspzz
Copy link
Owner

tmspzz commented Feb 22, 2019

@samritchie

If credentials are not discovered when a bucket is defined then an unauthenticated request should be made.

The CLI flag is needed to override the regular behavior when credentials are there. I suggest the flag to be --no-auth

http-conduit to /tmp/some-zip then move to the appropriate location and unpack.

@tmspzz
Copy link
Owner

tmspzz commented May 18, 2019

@LesterTheTester Thanks to @BalestraPatrick you can now use whatever backend you want, including implementing your own S3 script. #185

@tmspzz tmspzz closed this as completed May 18, 2019
@tmspzz
Copy link
Owner

tmspzz commented May 18, 2019

You can try the pre-release at: https://github.com/blender/Rome/releases/tag/v0.22.0.59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants