Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rome do not use env variables #149

Closed
chika-kasymov opened this issue Sep 9, 2018 · 11 comments
Closed

Rome do not use env variables #149

chika-kasymov opened this issue Sep 9, 2018 · 11 comments
Labels

Comments

@chika-kasymov
Copy link
Contributor

Enhancement Suggestion / Bug Report

When using environment variables I'm getting the same error both on local and CircleCI: ```rome: /Users/chika/.aws/config: openFile: does not exist (No such file or directory)```.

Steps which explain the enhancement or reproduce the bug

  1. Setup Rome
  2. Export AWS_REGION, AWS_ACCESS_KEY_ID, and AWS_SECRET_ACCESS_KEY variables
  3. Run any Rome command

Current behavior

See bug report.

Suggested behavior

Rome should execute commands properly without `.aws/config` and `.aws/credentials` files when necessary environment variables exist.

Why would the enhancement be useful to most users

That is a must-have feature for CI.

Rome version:

0.17.1.49

OS and version:

macOS High Sierra 10.13.6
@tmspzz
Copy link
Owner

tmspzz commented Sep 9, 2018

Thanks for opening an issue, this is a duplicate of #102

There is a workaround in that issue. It's not a problem with rome as far as I can tell. Reading env variables should work fine on your machine for example.

@tmspzz tmspzz closed this as completed Sep 9, 2018
@tmspzz tmspzz reopened this Sep 9, 2018
@tmspzz
Copy link
Owner

tmspzz commented Sep 9, 2018

Actually you said you get the same problem locally?

@chika-kasymov
Copy link
Contributor Author

Yes. I exported AWS variables and see them in env command output, but any Rome command fails.

@tmspzz
Copy link
Owner

tmspzz commented Sep 9, 2018

@chika-kasymov please try https://github.com/blender/Rome/releases/tag/v0.17.2.50 this should fix the problem locally. Can you please let me know if it also solves it on Circle?

@chika-kasymov
Copy link
Contributor Author

@blender sadly the fix doesn't solve the problem on both sides. Currently, I'm getting this error:

Failed reading: Failure parsing Region from asfd/Users/chika/.aws/config: openFile: does not exist (No such file or directory)

asdf here is the value of AWS_REGION.

@tmspzz
Copy link
Owner

tmspzz commented Sep 10, 2018

AWS_REGION must be a valid region. asdf is not a valid region

@tmspzz
Copy link
Owner

tmspzz commented Sep 10, 2018

Try with us-east-1 for example

@chika-kasymov
Copy link
Contributor Author

@blender sorry I tried asdf for testing purposes and didn't know Rome validates the value :) Yes, with correct value everything works now. But I can't get a new version using brew. Will it update automatically after a while?

@tmspzz
Copy link
Owner

tmspzz commented Sep 10, 2018

I will release via homebrew in the next 30 minutes and write back here.

@chika-kasymov
Copy link
Contributor Author

Thanks!

@tmspzz
Copy link
Owner

tmspzz commented Sep 10, 2018

@chika-kasymov done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants