Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for certain repositories to be ignored entirely #31

Closed
erichoracek opened this issue Oct 7, 2016 · 7 comments
Closed

Allow for certain repositories to be ignored entirely #31

erichoracek opened this issue Oct 7, 2016 · 7 comments

Comments

@erichoracek
Copy link

Some repositories use Carthage as a simple mechanism to include other git repositories that do not produce frameworks. Even Carthage itself does this, to include xcconfigs.

To accommodate for this existing paradigm, Rome should allow for certain repositories to be omitted entirely from the upload/download/list commands.

One could imagine that this would be an addition to the Romefile, along the same lines as the existing RepositoryMap section. Perhaps it could be named something along the lines of Ignored.

As a hypothetical example, let's imagine the following:

Cartfile:

github "Quick/Nimble"
github "jspahrsummers/xcconfigs"

Romefile:

[Ignored]
    xcconfigs

We then perform the following commands:

$ rome upload
Successfully uploaded Nimble to: Nimble/Nimble.framework-5.0.0.zip
Successfully uploaded Nimble to: Nimble/Nimble.framework.dSYM-5.0.0.zip
$ rome list
Nimble 5.0.0 ✔︎
$ rome download
Donwloaded: Nimble.framework-5.0.0.zip
Unzipped: Nimble.framework-5.0.0.zip
Donwloaded: Nimble.framework.dSYM-5.0.0.zip
Unzipped: Nimble.framework.dSYM-5.0.0.zip

Note that xcconfigs was never included in any of the hypothetical output.

Current Behavior:

Currently, in scenarios like these, users have to manually filter out repositories that fall into this category, since otherwise they will always show up when invoking rome list --missing.

While less of a hassle, this also pollutes the output of the download command with errors that will never be resolved:

$ rome download
...
Error downloading xcconfigs.framework-cc451b08e052b6146f5caf66bc1120420c529c7b.zip : The specified key does not exist.
Error downloading xcconfigs.framework.dSYM-cc451b08e052b6146f5caf66bc1120420c529c7b.zip : The specified key does not exist.
@tmspzz
Copy link
Owner

tmspzz commented Oct 7, 2016

Sounds good.

@tmspzz
Copy link
Owner

tmspzz commented Oct 8, 2016

@erichoracek Some clarification is needed

In the light of #30 adding an ignore section will look like this:

[RepositoryMap]
    awesome-cats = Caturday, CatCore

[IgnoreMap]
  xcconfigs = xcconfigs
  awesome-cat-names = CatCore

This allows selective ignoring when using aliases #12

Can this do?

@erichoracek
Copy link
Author

@blender sure, this will work

@tmspzz tmspzz mentioned this issue Oct 9, 2016
@tmspzz
Copy link
Owner

tmspzz commented Oct 9, 2016

@erichoracek please try pre-release v0.7.1.13

@tmspzz
Copy link
Owner

tmspzz commented Oct 13, 2016

@erichoracek seems to work as expected over here, do you have any input?

@erichoracek
Copy link
Author

@blender Appears to be working perfectly—thanks for taking a stab at this. Rome has been a joy to use.

@tmspzz
Copy link
Owner

tmspzz commented Oct 14, 2016

Thanks, maybe you have input on #38

@tmspzz tmspzz closed this as completed Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants