Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspace feature for example #79

Merged
merged 3 commits into from
Oct 14, 2023
Merged

chore: use workspace feature for example #79

merged 3 commits into from
Oct 14, 2023

Conversation

tobiasdiez
Copy link
Owner

@tobiasdiez tobiasdiez commented Oct 13, 2023

Fixes #75.

@floroz is this what you had in mind? I don't think we need to move the src folder for this since the root is always added as a worskpace. I didn't touch the playground, which is there anyway only for quick local tests.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #79 (c51229b) into main (84d9eb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files           3        3           
  Lines         345      345           
  Branches       55       55           
=======================================
  Hits          323      323           
  Misses         22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@floroz floroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works like a charm 😄

There is one gotcha that is probably not related to this change, but good to keep in mind.

It seems that once storybook bootstraps initially, and the vite dependencies are optimized and cached (including storybook-vue-addon), changes to the packages done while in dev (tsup --watch) are not reflected in Storybook.

This means that when developing/debugging, it's necessary to restart the Storybook dev server to see the changes reflected.

There is probably a way to invalidate the cache, but I have been bitten more often trying to do that, then accepting a manual hard reload..

@tobiasdiez
Copy link
Owner Author

Thanks for giving this a try! The caching is indeed a bit annoying, but I'm not even sure if vite supports hmr of plugins even in principle. So yes, restarting everything from scratch it is for now.

@tobiasdiez tobiasdiez merged commit fb512c8 into main Oct 14, 2023
11 checks passed
@tobiasdiez tobiasdiez deleted the workspace_deps branch October 14, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for E2E testing of addon distribution
2 participants