Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated controls on resource details screen #258

Closed
hawkw opened this issue Jan 10, 2022 · 3 comments
Closed

duplicated controls on resource details screen #258

hawkw opened this issue Jan 10, 2022 · 3 comments
Assignees
Labels
C-console Crate: console. E-easy Effort: easy. Good for newcomers S-bug Severity: bug

Comments

@hawkw
Copy link
Member

hawkw commented Jan 10, 2022

It looks like the resource details screen currently has two separate "controls" help sections, one of which is for the details screen and the other of which is for the table:
image

I believe the top one is rendered by the details view, and the lower one is rendered by the table itself.

This is not the case for the task details view, because it doesn't include a table element:
image

We might want to combine these? Or...maybe it's fine? What do people think?

@hds
Copy link
Collaborator

hds commented Feb 12, 2024

This issue is is still valid on main.

It is a little bit better. All the controls are now rendered at the top of the resource detail screen. However, the controls for the table of Async Ops is still rendered above that table and need to be removed.

tokio-console-screenshot-2024-February-11-81427

The controls that are rendered at the top of the Async Ops table come from here. This can be removed and then the necessary cleanup performed so that we don't have unused variables hanging around.

frame.render_widget(controls.into_widget(), controls_area);

Hint: There is a split(area) which is no longer necessary.

@hds hds added S-bug Severity: bug E-easy Effort: easy. Good for newcomers C-console Crate: console. labels Feb 12, 2024
@devanbenz
Copy link
Contributor

@hds Thanks for the updates here, could you please go ahead and assign this issue to me :D

@devanbenz
Copy link
Contributor

#519 this is the PR for this issue :)

@hds hds closed this as completed in f28ba4a Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-console Crate: console. E-easy Effort: easy. Good for newcomers S-bug Severity: bug
Projects
None yet
Development

No branches or pull requests

3 participants