Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readable/writeable/ready methods to read/write half #4098

Closed
Darksonn opened this issue Sep 9, 2021 · 3 comments · Fixed by #4120
Closed

Add readable/writeable/ready methods to read/write half #4098

Darksonn opened this issue Sep 9, 2021 · 3 comments · Fixed by #4120
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-net Module: tokio/net

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Sep 9, 2021

It would make sense for the various socket type read/write halves have the readable/writeable/ready methods, as well as the try_* methods.
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net C-feature-request Category: A feature request. labels Sep 9, 2021
@Darksonn Darksonn mentioned this issue Sep 9, 2021
Closed
@Darksonn Darksonn added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 19, 2021
@Noah-Kennedy
Copy link
Contributor

I think I'll give this one a go.

@Noah-Kennedy
Copy link
Contributor

On this note, I think peer_addr is also a potentially useful function to have here.

@Noah-Kennedy Noah-Kennedy mentioned this issue Sep 19, 2021
Merged
@Noah-Kennedy
Copy link
Contributor

I've got a PR up now to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add try_*, readable, writable, ready, and peer_addr methods to TCP and Unix split halves
2 participants
@Darksonn @Noah-Kennedy