Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO primitives should hook into coop #6249

Closed
Darksonn opened this issue Dec 26, 2023 · 1 comment · Fixed by #6254
Closed

IO primitives should hook into coop #6249

Darksonn opened this issue Dec 26, 2023 · 1 comment · Fixed by #6254
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. M-coop Module: tokio/coop M-io Module: tokio/io

Comments

@Darksonn
Copy link
Contributor

The IO primitives repeat and sink will always succeed without checking the coop budget. (There may be others.) They should be changed to yield if the coop budget is consumed.
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io M-coop Module: tokio/coop E-help-wanted Call for participation: Help is requested to fix this issue. labels Dec 26, 2023
@mox692
Copy link
Member

mox692 commented Dec 27, 2023

Hi team, I'll work on this.

@mox692 mox692 mentioned this issue Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. M-coop Module: tokio/coop M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

io: make repeat and sink cooperative mox692/tokio
2 participants
@Darksonn @mox692