Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appender: Configurable timeout for WorkerGuard shutdown signal #1135

Open
zekisherif opened this issue Dec 11, 2020 · 0 comments
Open

appender: Configurable timeout for WorkerGuard shutdown signal #1135

zekisherif opened this issue Dec 11, 2020 · 0 comments

Comments

@zekisherif
Copy link
Contributor

Feature Request

Crates

tracing-appender

Motivation

In #1125 it was identified that the timeout used for waiting on the Worker thread to finish flushing events to disk should be configurable. Currently there is a default timeout of 1000 ms. This default wasn't chosen for a specific reason and it would be better to let the end user decide what is the correct value for their application.

Proposal

Add a new worker_shutdown_timeout field to NonBlockingBuilder which the WorkerGuard will use when it's dropped.

Alternatives

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant