Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows hiding tooltips message in the outside of new track menu or only showing them when the menu is first opened #955

Closed
dyphire opened this issue Aug 30, 2024 · 11 comments

Comments

@dyphire
Copy link
Contributor

dyphire commented Aug 30, 2024

image
Personally I don't like seeing this tooltips message all the time.

@dyphire dyphire changed the title Allows hiding tooltips outside the new track menu or only showing them when the menu is first opened Allows hiding tooltips message the new track menu or only showing them when the menu is first opened Aug 30, 2024
@dyphire dyphire changed the title Allows hiding tooltips message the new track menu or only showing them when the menu is first opened Allows hiding tooltips message in the outside of new track menu or only showing them when the menu is first opened Aug 30, 2024
@tomasklaen
Copy link
Owner

I've tried to make it discrete so it doesn't bother anyone, so of course it bothers someone 😭.

Will you really not get used to it? Does it really bother you that much? Do we really have to have an option for this little line there?

@Sneakpeakcss
Copy link
Contributor

On one hand, it's nice that we now have clear descriptions of "hidden" actions in the menus (modifiers etc.), so it doesn't rely on going through the whole docummentation and remembering rarely used actions, and on the other, this one seems a bit in the face, even when the menu is rarely opened.

This is one of those things that would look better as a / 🅘 sign somewhere in the corner that can be hovered to display a tooltip. If that's currently possible to implement then i would vote for that solution.

@dyphire
Copy link
Contributor Author

dyphire commented Aug 30, 2024

I've tried to make it discrete so it doesn't bother anyone, so of course it bothers someone 😭.

Will you really not get used to it? Does it really bother you that much? Do we really have to have an option for this little line there?

It's a bit ugly to me and reduces my interest in opening the track menu.

On one hand, it's nice that we now have clear descriptions of "hidden" actions in the menus (modifiers etc.), so it doesn't rely on going through the whole docummentation and remembering rarely used actions, and on the other, this one seems a bit in the face, even when the menu is rarely opened.

This is one of those things that would look better as a / 🅘 sign somewhere in the corner that can be hovered to display a tooltip. If that's currently possible to implement then i would vote for that solution.

This suggestion sounds good, and we're totally can provide a / 🅘 sign for tooltips.

@tomasklaen
Copy link
Owner

Yeah that's not a bad suggestion.

@tomasklaen
Copy link
Owner

footnote

@dyphire
Copy link
Contributor Author

dyphire commented Aug 30, 2024

footnote

LGTM.

What I'm more curious about now is why the action signs in the file menu are placed inside the menu, why it behaves differently.

@tomasklaen
Copy link
Owner

tomasklaen commented Aug 30, 2024

What I'm more curious about now is why the action signs in the file menu are placed inside the menu, why it behaves differently.

I'm trying to minimize clashing of item icon/hint with actions:

  • If item has no icon & no hint -> always inside. (no icon/hint to clash with/cover)
  • If item does have an icon or hint, and there is space for them to be outside -> outside.
  • If there's no space outside -> inside, even if it covers icon or hint.

@Sneakpeakcss
Copy link
Contributor

Yeah, this is far better. The only nitpick i would have is that the help/help_outline icon is more 'visually shifting' than the info/info_outline :

help.mp4
info.mp4

Though at this scale info looks a bit like a semicolon, but that might be just me being blind.

@Solarunit
Copy link

Solarunit commented Aug 30, 2024

I haven't tried these new features yet, but looking on screenshots/gifs, I don't like it either - any tooltips below the menu.
I would like to have option to hide it. (I never Paste anything to mpv)

Not sure about new way to enable/disable subtitles, I need to test it first.

@Solarunit
Copy link

So, I tested latest version 5.3.1 and yes, I wish there was a way to hide that 🅘 sign and also Activate as secondary subs button. I do not plan to use secondary subs but I am forced to see this button every time now.

@poslat-pismo
Copy link

Please make an optoin in "disable_elements" or something to get rid of this help sign and tooltips in playlist (the arrow and trash buttons are awesome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants