Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when upgrading from 3.0.0 to 5.0.0 #327

Closed
jerefrer opened this issue Aug 15, 2016 · 3 comments
Closed

Error when upgrading from 3.0.0 to 5.0.0 #327

jerefrer opened this issue Aug 15, 2016 · 3 comments

Comments

@jerefrer
Copy link

jerefrer commented Aug 15, 2016

I'm trying to upgrade from 3.0.0 to 5.0.0, which requires that I also upgrade React from 0.13.3 to 15.1.0.

I've dealt with a number of things, like the need to wrap GoogleMap inside a GoogleMapLoader.

I got things almost working, but now I'm struggling with this error:

common.js:230 Uncaught RangeError: Maximum call stack size exceeded
  _.m.zoom_changed._.dy.zoomRange_changed @ common.js:230
  xb @ js:37
  _.m.set @ js:97
  (anonymous function) @ js:47
  _.m.zoom_changed._.dy.zoomRange_changed @ common.js:230
  xb @ js:37
  _.m.set @ js:97
  (anonymous function) @ js:47
  _.m.zoom_changed._.dy.zoomRange_changed @ common.js:230
  xb @ js:37

whenever move the map or zoom in/out after I started to fiddle with markers, like hiding or showing some of them or opening an InfoWindow.

I found a few possible explanations on SO posts : like this one, or that one.

Any idea from your perspective ?

@jerefrer jerefrer changed the title Upgrade from 3.0.0 to 5.0.0 Error when upgrading from 3.0.0 to 5.0.0 Aug 15, 2016
@wnoveno
Copy link

wnoveno commented Aug 18, 2016

I'm having the same problem. It's actually really weird since I'm not passing any data to the component yet. Would love to know the solution to this as well

@jerefrer
Copy link
Author

I gave up using react-google-map and went to vanilla Google Map.
Everything went well and I decided to add a feature related to the zoom.
Then I encountered the same error when I passed an undefined zoom when initializing the map.

So maybe there is some issue while passing the defaultZoom prop ?

@tomchentw
Copy link
Owner

@jerefrer @wnoveno don't use 5.0.0. Please try 6.0.0 instead. This bug is fixed now.

6.0.0 is released on npm beta tag now. We also have a new demo page. Feel free to try it:
https://tomchentw.github.io/react-google-maps/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants