-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HeatmapLayer): HeatmapLayer constructor fix #376
Conversation
HeatmapLayer should use google.maps.visualization.HeatmapLayer() as the constructor. See here for more information: https://developers.google.com/maps/documentation/javascript/3.exp/reference#HeatmapLayer. tomchentw#375
+1 on this, HeatmapLayer breaks without this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct necessary change
Will the heatmap issue be fixed any soon? |
No. The code base is abandoned. @RishabhJain96 wants to take it over but hasn't heard from @tomchentw . |
I think I will formally fork the project soon, but I'm still hoping to hear back from @tomchentw |
its so sad that a great project is not being supported anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the correct way. HeatMap does not work otherwise.
Released 6.0.3 |
HeatmapLayer should use google.maps.visualization.HeatmapLayer() as the constructor. See here for more information: https://developers.google.com/maps/documentation/javascript/3.exp/reference#HeatmapLayer.
#375