Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HeatmapLayer): HeatmapLayer constructor fix #376

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

RishabhJain96
Copy link
Contributor

HeatmapLayer should use google.maps.visualization.HeatmapLayer() as the constructor. See here for more information: https://developers.google.com/maps/documentation/javascript/3.exp/reference#HeatmapLayer.

#375

HeatmapLayer should use google.maps.visualization.HeatmapLayer() as the constructor. See here for

more information:

https://developers.google.com/maps/documentation/javascript/3.exp/reference#HeatmapLayer.

tomchentw#375
@cosmith
Copy link

cosmith commented Dec 5, 2016

+1 on this, HeatmapLayer breaks without this fix.

Copy link

@ZephD ZephD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct necessary change

@noushad-pp
Copy link

Will the heatmap issue be fixed any soon?

@ZephD
Copy link

ZephD commented Jan 24, 2017

No. The code base is abandoned. @RishabhJain96 wants to take it over but hasn't heard from @tomchentw .

@RishabhJain96
Copy link
Contributor Author

I think I will formally fork the project soon, but I'm still hoping to hear back from @tomchentw

@noushad-pp
Copy link

its so sad that a great project is not being supported anymore.

Copy link

@SabeehY SabeehY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the correct way. HeatMap does not work otherwise.

@tomchentw tomchentw merged commit 24b140d into tomchentw:master Apr 20, 2017
@tomchentw
Copy link
Owner

Released 6.0.3

@tomchentw tomchentw mentioned this pull request Apr 20, 2017
tomchentw added a commit that referenced this pull request Apr 20, 2017
@tomchentw
Copy link
Owner

For better namespacing, I've moved it to under visualization/ folder. See #470 for more details about the changes.

Released 6.1.0

tomchentw added a commit that referenced this pull request Apr 21, 2017
* Ref #470, #376, #375

BREAKING CHANGE: remove top-level HeatmapLayer export

Before:

```js
import { HeatmapLayer } from "react-google-maps"
```

After:

```js
import HeatmapLayer from "react-google-maps/lib/visualization/HeatmapLayer"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants