feat(Declarative Bounds) specify map bounds via props #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /*eslint-enable no-unused-vars */ | ||
| var {instance} = this.state; | ||
|
|
||
| if (bounds) { |
There was a problem hiding this comment.
Why deletion is needed when bounds is present?
There was a problem hiding this comment.
As far as I understand it, fitBounds actually sets zoom/center. So this is a precaution to prevent the map from jumping around.
tomchentw
pushed a commit
that referenced
this pull request
Jun 19, 2015
* Thanks to @petebrowne * Original commit: a4b48a1 * Closes #64
|
Released as v.1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying the map bounds via props. This allows you to use the GoogleMaps component in a standard declarative way, instead of interacting with the map instance.