Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo dissipation with tuple closures #86

Open
tomchor opened this issue Aug 25, 2022 · 3 comments
Open

Pseudo dissipation with tuple closures #86

tomchor opened this issue Aug 25, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tomchor
Copy link
Owner

tomchor commented Aug 25, 2022

At the moment we can't get (pseudo)-dissipation when the model has a tuple closure.

I'm not sure if it's possible to get actual dissipation when the diffusivity isn't isotropic, but it should be straightforward to get pseudo-dissipation.

@glwagner
Copy link
Collaborator

We also can't get dissipation when the closure doesn't use an eddy diffusivity, right? So it's not possible to calculate diffusivity for any turbulence closure.

@tomchor
Copy link
Owner Author

tomchor commented Aug 25, 2022

We also can't get dissipation when the closure doesn't use an eddy diffusivity, right? So it's not possible to calculate diffusivity for any turbulence closure.

True. Although we could consider throwing a useful error in those cases?

I think we should at least support the common cases (like (VerticalDiffusivity(), HorizontalDiffusivity())) though, especially because it should be pretty straightforward.

@glwagner
Copy link
Collaborator

Agree, it makes sense to try to support any AbstractScalarDiffusivity since it's calculable and there's an interface. We can also support tuples of AbstractScalarDiffusivity I think, via https://github.com/CliMA/Oceananigans.jl/blob/ce5ba71449cf16b8737dca10997a6119dee4c665/src/TurbulenceClosures/abstract_scalar_diffusivity_closure.jl#L61-L62

@tomchor tomchor added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants