Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toml-test an official TOML product and move to github.com/toml-lang org #42

Closed
mojombo opened this issue Jan 7, 2017 · 13 comments
Closed

Comments

@mojombo
Copy link
Member

mojombo commented Jan 7, 2017

I'd love for toml-test to become the official test suite for TOML implementations. If you're into that idea, we could move it to the toml-lang org on GitHub so people know it's the real deal. Once it's updated for the imminent 1.0 release, I'd like to create an easy way for implementors to get their implementation's test results published on the upcoming TOML marketing website so others can see which implementations are production ready.

@mojombo
Copy link
Member Author

mojombo commented Jan 10, 2017

@BurntSushi If you're into this idea, I'll put some effort into getting this up to date for the latest TOML on master.

@BurntSushi
Copy link
Member

@mojombo I'm definitely interested. I haven't had as much time for TOML lately as I'd like, but I'd be happy to hand over or share maintenance of this repo!

@BurntSushi
Copy link
Member

@mojombo I've invited you!

@BurntSushi
Copy link
Member

And moving this into the toml-lang org sounds good to me!

@mojombo
Copy link
Member Author

mojombo commented Jan 10, 2017

Awesome! I'll work on getting this compliant with master and then move it into the TOML org. Booyah!

@samvasko
Copy link

samvasko commented Mar 12, 2017

@mojombo I am be happy to help with speeding up the transition. I would really like to see some of the pull requests merged.

@pradyunsg
Copy link
Member

@BurntSushi Are you still interested in moving this forward?

Let's sync up with the current master, in preparation for whenever we have a TOML 1.0.

@BurntSushi
Copy link
Member

I don't have time, sorry.

@uiri
Copy link
Collaborator

uiri commented Jul 3, 2018

@pradyunsg @mojombo Are there still plans to move this toml-test repo into the toml-lang org?

I have merged in all the non-code change PRs (i.e. more test cases and additions to the README) and cleaned up the easy, "quick fix" issues. Are any of the remaining PRs and issues things which you would like to see merged/fixed before moving the repo?

@sgarciac
Copy link
Contributor

sgarciac commented Jul 14, 2018

It would have been nice if you had created a release for TOML 0.3. I think no post-0.4 features tests should be merged before creating a release for TOML 0.4, even if TOML 0.5 has been released. It will take some time before most TOML parsers are upgraded to the new version and it will be nice to have a test suite that TOML 0.4 compliant parsers can use.

@eksortso
Copy link

@sgarciac Did you turn all the 0.n's into en-dot-ohs there, or something?

@sgarciac
Copy link
Contributor

@eksortso ha! ouch, indeed. Fixed.

@arp242
Copy link
Collaborator

arp242 commented Jun 25, 2021

Being discussed in the toml repo as well; see my comment there: toml-lang/toml#585 (comment)

Not sure if there's any point keeping this one open, so closing it in favour of the issue on the toml repo.

@arp242 arp242 closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants