Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Support for u128, i128 integer types #266

Closed
AregevDev opened this issue Oct 21, 2018 · 10 comments
Closed

Support for u128, i128 integer types #266

AregevDev opened this issue Oct 21, 2018 · 10 comments

Comments

@AregevDev
Copy link

Pretty self-explained, serde is already support them, will be nice to see them in the TOML format

@alexcrichton
Copy link
Collaborator

Thanks for the report! Can you gist an example of what doesn't work to have a good test case to check in?

@AregevDev
Copy link
Author

Sure thing, will be done when I will be back

@AregevDev
Copy link
Author

@AregevDev
Copy link
Author

Any news?

@AregevDev
Copy link
Author

I serialized a struct with two 128 bit integers successfully but deserializing them is the tricky part

@AregevDev
Copy link
Author

Built from source and modified a little

@AregevDev
Copy link
Author

Solved, I can deserialize i/u128 which are not overflowing the i/u64::max_value() perspectively

@nullchinchilla
Copy link

I'd like to bump this issue a bit, since it's quite a critical feature for my use case.

@TheDarkula
Copy link

TheDarkula commented Sep 23, 2021

I opened a pull request to add this functionality: #445

Unfortunately, I read through the code, and it seems like this would take a good bit of rewriting.
From what I can tell from here and here, all integers are interpreted as an i64, which seems inefficient.

@epage
Copy link
Member

epage commented Sep 23, 2022

Maintenance of this crate has moved to the https://github.com/toml-rs/toml repo. As a heads up, we plan to move toml to be on top of toml_edit, see toml-rs/toml#340.

Closing this out. If this is still a problem, feel free to recreate this issue in the new repo.

@epage epage closed this as completed Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants