Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TOML 1.1 release #397

Open
epage opened this issue Dec 19, 2022 · 5 comments
Open

Support TOML 1.1 release #397

epage opened this issue Dec 19, 2022 · 5 comments
Labels
A-output Area: Outputting TOML A-parse Area: Parsing TOML C-enhancement Category: Raise on the bar on expectations

Comments

@epage
Copy link
Member

epage commented Dec 19, 2022

atm the next toml release contains

  • Aligning inline tables with inline arrays
  • Unicode bare identifiers
  • etc

The unicode one will be a challenge as it might require us to stop using byte parsing and switch back to UTF-8 parsing which would slow us down a good chunk (#219). Its not clear if they reused any existing unicode definitions like xid_continue, so I asked in toml-lang/toml#891

@epage epage added C-enhancement Category: Raise on the bar on expectations A-parse Area: Parsing TOML A-output Area: Outputting TOML labels Dec 19, 2022
@epage
Copy link
Member Author

epage commented May 31, 2023

Note: this is blocked on the release being out but meant for our tracking of it

@wolfv
Copy link

wolfv commented Jul 13, 2023

Has there been any progress on the inline-table with multiline support? I looked at some of the history but couldn't find anything yet. I think it's a nice usability improvement in certain cases.

We might be able to spend some time at @prefix-dev if the feature is desired.

@epage
Copy link
Member Author

epage commented Jul 13, 2023

At this time, I'd rather not be supporting unreleased TOML specs.

The issue for TOML 1.1 spec is toml-lang/toml#928

@wolfv
Copy link

wolfv commented Jul 17, 2023

And if we would put it behind a feature flag like toml-next or toml-1.1? Would you be open to accept a PR?

@epage
Copy link
Member Author

epage commented Jul 17, 2023

That could get quite messy maintaining different subsets of the parsers like that.

We'd also need a good way of dividing the conformance tests to handle that.

I would also make it a unstable-toml-1.1 flag because it could have breaking format changes.

Overall, this does not seem worth doing, especially because its not guaranteed that the approved parts of the format will stay as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-output Area: Outputting TOML A-parse Area: Parsing TOML C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

2 participants