Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow coverlet integration with other MSBuild test strategies #615

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

sharwell
Copy link
Contributor

This change exposes the InstrumentModules and GenerateCoverageResult targets which execute unconditionally, and can then be tied into build steps using conditional logic. The previous logic for supporting the VSTest target is retained through conditional targets.

This change exposes the InstrumentModules and GenerateCoverageResult
targets which execute unconditionally, and can then be tied into build
steps using conditional logic. The previous logic for supporting the
VSTest target is retained through conditional targets.
@MarcoRossignoli
Copy link
Collaborator

@sharwell where do you need it?

@MarcoRossignoli MarcoRossignoli added enhancement General enhancement request driver-msbuild Issue related to msbuild driver labels Nov 12, 2019
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoRossignoli MarcoRossignoli merged commit 14205af into coverlet-coverage:master Nov 12, 2019
@sharwell
Copy link
Contributor Author

@MarcoRossignoli I had to duplicate most of the targets file in dotnet/roslyn-analyzers#3028. With this change, I'll be able to just duplicate the InstrumentModulesNoBuild and GenerateCoverageResultAfterTest targets.

@MarcoRossignoli
Copy link
Collaborator

Understood...I don't have idea of release at the moment we're discussing off line...if you want to use this you can dogfood it tomorrow https://github.com/tonerdo/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

@MarcoRossignoli
Copy link
Collaborator

@sharwell
Copy link
Contributor Author

@MarcoRossignoli Thanks. I'll test out the nightly but there's no rush on the release itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver-msbuild Issue related to msbuild driver enhancement General enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants