-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide compiler generated branches for try/catch blocks inside async state machine #716
Hide compiler generated branches for try/catch blocks inside async state machine #716
Conversation
The idea generally is ok to me, we need to be sure that if heuristics fail instrumentation go on, so some more check is not a great problem...I prefer worste perf than fail. |
Please can you attach a full IL source of |
@MarcoRossignoli PTAL I improved the heuristic logic and added several tests to validate it. |
Attach generated IL for MoveNext() of this example (nested try/catch blocks with conditional exception rethrown) |
I'm checking...I need some time, this fix is "articulated", thank's |
@matteoerigozzi can you rebase? |
@MarcoRossignoli rebased! |
@matteoerigozzi have you tried to generate a report in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great job!
Fixes #465
Improve compiler generated branches detection inside MoveNext() method of async state machine.
This core remove all unexpected branches