Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty no longer supports Fira Code after updating to 3.1 #1000

Closed
cyanic-selkie opened this issue Apr 14, 2020 · 5 comments
Closed

kitty no longer supports Fira Code after updating to 3.1 #1000

cyanic-selkie opened this issue Apr 14, 2020 · 5 comments
Labels
Milestone

Comments

@cyanic-selkie
Copy link

cyanic-selkie commented Apr 14, 2020

Running kitty list-fonts no longer finds Fira Code as a compatible font. This happened after updating from 2.1 to 3.1. Before the update everything worked perfectly.

@trygveaa
Copy link

This is caused by the spacing property missing:

Version 2

$ fc-query /usr/share/fonts/TTF/FiraCode-Regular.ttf | grep spacing
	spacing: 90(i)(s)

Version 3

$ fc-query /usr/share/fonts/TTF/FiraCode-Regular.ttf | grep spacing
$ 

@idabmat
Copy link

idabmat commented Apr 14, 2020

There seems to be a workaround for it : #840

@tonsky
Copy link
Owner

tonsky commented Apr 14, 2020

Thanks, I’ll try to fix this ASAP

@tonsky tonsky added the bug label Apr 14, 2020
@TheConfuZzledDude
Copy link

The list of characters which don't have a width of 1200 or 0 are:

uni1E9E 1199
uni300C 1100
uniFF62 600
uniFF63 600
uni27F2 2400
uni27F3 2400
uni27F4 2400
uni27F5 2400
uni27F6 2400
uni27F7 2400
uni27F8 2400
uni27F9 2400
uni27FA 2400
uni27FB 2400
uni27FC 2400
uni27FD 2400
uni27FE 2400
uni27FF 2400
uni2388 2400
uni2415 1194

I believe the only ones which would prevent fontconfig from recognising them as dual spaced are

uni300C 1100
uniFF62 600
uniFF63 600

Since it doesn't consider them to be "approximately equal" to 1200

@tonsky tonsky added this to the 3.1 milestone Apr 15, 2020
@tonsky tonsky closed this as completed in 6d37581 Apr 15, 2020
@tonsky
Copy link
Owner

tonsky commented Apr 15, 2020

Hopefully fixed in 3.1

[~/iCloud/ws/FiraCode] fc-query distr/ttf/FiraCode-Regular.ttf | grep spacing
	spacing: 90(i)(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants