Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiraCode 5.1 looks broken at 11pt #1075

Closed
CheloXL opened this issue Jun 10, 2020 · 9 comments
Closed

FiraCode 5.1 looks broken at 11pt #1075

CheloXL opened this issue Jun 10, 2020 · 9 comments

Comments

@CheloXL
Copy link

CheloXL commented Jun 10, 2020

I just updated to 5.1. Using the "Retina" variant, at 11px (in Visual Studio), I'm getting the following:

image

This doesn't happens on 5.

@tigerinus
Copy link

Also looks broken at 9pt under Windows Terminal:

image
image

@RubenVerg
Copy link

RubenVerg commented Jun 11, 2020 via email

@tonsky
Copy link
Owner

tonsky commented Jun 11, 2020

@CheloXL @tigerinus can you try this build? Does it make things better?
Fira_Code_v5.1.glyphs.zip

@tonsky
Copy link
Owner

tonsky commented Jun 11, 2020

And this one too please. These are just the different ways to export the same source. They all look identical on Mac, but apparently on Windows one way is better than the other. Thanks!

Fira_Code_v5.1.no_compat.zip

@CheloXL
Copy link
Author

CheloXL commented Jun 11, 2020

@tonsky Glyphs looks great, no_compat looks worst than the original 5.1

@tonsky
Copy link
Owner

tonsky commented Jun 11, 2020

I did my own bit of testing. no_compat renders m too low, for some reason:

Annotation 2020-06-11 165259

Glyphs is mostly fine, but //=// got butchered:

Annotation 2020-06-11 165554

@CheloXL can you provide a screenshot how no_compat looks for you? Just curious.

I think I’ll wait for @tigerinus to respond, but most likely I’ll stick with Glyphs from now on.

@CheloXL
Copy link
Author

CheloXL commented Jun 11, 2020

@tonsky Here you have:
image
Also, on MY machine on VS, //=// shows just fine.

@tigerinus
Copy link

with no_compat fonts, the problem seems to be better but not completely gone:

image
image

with 'glyphs' fonts, the problem is completely gone:

image
image

@tonsky
Copy link
Owner

tonsky commented Jun 12, 2020

Ok thanks, I’ll stick with the Glyphs export from now on. Sorry for the hiccup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants