Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-array? throws exception on nil in clj #4

Closed
timothypratley opened this issue Jun 23, 2021 · 2 comments · Fixed by #5
Closed

is-array? throws exception on nil in clj #4

timothypratley opened this issue Jun 23, 2021 · 2 comments · Fixed by #5

Comments

@timothypratley
Copy link
Contributor

A minor annoyance that causes an downstream issue:
(d/conn-from-datoms (d/datoms @*conn :eavt) schema) will fail on an empty database.
This is the recommended way to update a schema from DataScript documentation.
This in turn can be easily worked around by only using conn-from-datoms for non-nil.

However type checks typically shouldn't throw exceptions, so submitting a patch.

@tonsky
Copy link
Owner

tonsky commented Jun 23, 2021

Thank you! Just pushed DataScript 1.2.1

@timothypratley
Copy link
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants