Experiment: Convert .gitignore entries to radon ignore/exlude #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 95.46% 95.52% +0.05%
==========================================
Files 26 26
Lines 1346 1364 +18
Branches 287 291 +4
==========================================
+ Hits 1285 1303 +18
Misses 37 37
Partials 24 24 ☔ View full report in Codecov by Sentry. |
|
lmk when this is ready to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO in build.py: "Convert .gitignore to radon ignore patterns to make the build more efficient". However, timings show no difference in performance even with a lot of added Python files in ignored directories. That happens because radon is called only with modified files from given revisions as targets, so the build is already optimal in this sense.
This PR serves only to document this exploration. Leaving it open for a while in case we can identify a scenario it would help with.